Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add grubalt bootchooser #1275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add grubalt bootchooser #1275

wants to merge 1 commit into from

Conversation

mbessler
Copy link

The grubalt bootchooser is an alternative Grub-based bootchooser that works more like the uboot bootchoser.

The grubalt bootchooser requires Grub built with decrement support. Currently this feature requires patching Grub: https://src.fedoraproject.org/rpms/grub2/blob/db4a99687c8306760702abda9c01a2e74d19a3f3/f/0253-Reimplement-boot_counter.patch

@jluebbe jluebbe added the enhancement Adds new functionality or enhanced handling to RAUC label Oct 26, 2023
@jluebbe jluebbe self-requested a review December 5, 2023 11:51
@jluebbe jluebbe self-assigned this Dec 5, 2023
The grubalt bootchooser is an alternative Grub-based
bootchooser that works more like the uboot bootchoser.

The grubalt bootchooser requires Grub built with decrement
support. Currently this feature requires patching Grub:
https://src.fedoraproject.org/rpms/grub2/blob/db4a99687c8306760702abda9c01a2e74d19a3f3/f/0253-Reimplement-boot_counter.patch

Signed-off-by: Manuel Bessler <[email protected]>
@jluebbe
Copy link
Member

jluebbe commented Dec 5, 2023

Rebased to master to retrigger CI.

Copy link
Member

@jluebbe jluebbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks looks good, although I'd prefer something like "grub-counting" as the name, as "alt" is too generic.

Before merging this, we'd prefer having the corresponding support upstream in grub. @mbessler, are you aware of attempts to get this merged? I've not found any in a quick search.

We can leave this PR open so anyone can use it together with the grub patch, of course.

@jluebbe jluebbe assigned mbessler and unassigned jluebbe Dec 5, 2023
@mbessler
Copy link
Author

mbessler commented Dec 5, 2023

The code looks looks good, although I'd prefer something like "grub-counting" as the name, as "alt" is too generic.

Sounds like a better name choice than mine :) I'll see when I can update the names and push an update.

Before merging this, we'd prefer having the corresponding support upstream in grub. @mbessler, are you aware of attempts to get this merged? I've not found any in a quick search.

I've not tried engaging with the Grub team. If someone else wants to try, please do.

We can leave this PR open so anyone can use it together with the grub patch, of course.

How about carrying the patch in meta-rauc until upstream Grub integrates it (if ever)?

@ejoerns
Copy link
Member

ejoerns commented Dec 20, 2023

@mbessler We could have both patch sets in meta-rauc, yes. This would at least ensure that we have a consistent environment.
However, at the moment I am not yet very convinced that this is a better option than finding someone who has an interest in pushing these things towards GRUB mainline, because it means additional maintenance effort for meta-rauc without knowing if it is actually used or a benefit for others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adds new functionality or enhanced handling to RAUC help wanted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants