Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in sample code of ch15, layers API #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hanocha
Copy link

@hanocha hanocha commented Mar 8, 2020

Dear author,

Hi :)
I found mistakes in chapter 15, sample codes of Tensorflow layers API.

The sample code with validation_set, it outputs results of validation almost 1.00, it seems strange to me.
Maybe we should use validation_set argument in the block of if.

And this PR includes some of fixes about white spaces of the end of line, and blank lines.
It was auto corrected when I saved the file.
If you don't line the differences, please mention to me. I'll modify it.

@pep8speaks
Copy link

Hello @hanocha! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 333:1: E266 too many leading '#' for block comment
Line 340:9: E266 too many leading '#' for block comment
Line 456:35: E231 missing whitespace after ','
Line 459:5: E266 too many leading '#' for block comment
Line 604:1: E266 too many leading '#' for block comment
Line 620:1: E266 too many leading '#' for block comment
Line 641:1: E266 too many leading '#' for block comment
Line 652:1: E266 too many leading '#' for block comment
Line 669:1: E266 too many leading '#' for block comment
Line 690:1: E266 too many leading '#' for block comment
Line 749:5: E266 too many leading '#' for block comment
Line 850:9: E266 too many leading '#' for block comment
Line 866:31: E128 continuation line under-indented for visual indent
Line 869:54: E231 missing whitespace after ','
Line 872:9: E266 too many leading '#' for block comment
Line 874:31: E128 continuation line under-indented for visual indent
Line 946:24: E222 multiple spaces after operator

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants