V2 refactor #58
Open
V2 refactor #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…now. Incrementally building.
…rrors in ts on Core class
… a declarations folder and properly import.
…s. Move warn to debug utils
Note: The h1 could have SEO issues with the strong tags around api in rapid.js but looks nice.
I believe this should generate d.ts files automatically but we'll see when we get there.
I've added auth as a key on the Config for now until we can determine if it's optional.
I tossed in some heavy comments about `initializeHttp` I tried to interpret it to my best.
A few code smells were marked with TODO
This is just the dirty to get it transpiling.
V2 refactor
…ile compiling code in .gitignore
…ile compiling code in .gitignore (cherry picked from commit 97699ce)
See: #41 * Renamed to CustomeRouteOptions * Put the interface to custome-route.ts, so we can kill custom-route.d.ts * Adopt change in all other files
#41 * add AuthConfig interface to config.d.ts * kill auth-config.d.ts * adopt the changes
See: #41 * merge RequestType, RequestData into core/request.ts * remove typings/request.d.ts
See: #41 * relocate to src/core * adopt changes in depending files
See: #41 * relocate interface to src/core * remove typings dir
See: #41 * add missing files to commit
See: #41 * add missing files to commit
#41 * This will then compile js files to dist
#41 * Set path to main types rapid.d.ts
add .editorconfig and edit .gitignore
See #rapidjs/rapid.js-41
See #rapidjs/rapid.js-41
Rapid.js 41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.