Skip to content
This repository has been archived by the owner on May 25, 2021. It is now read-only.

Fix language of code block #1452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix language of code block #1452

wants to merge 1 commit into from

Conversation

munierujp
Copy link

Comment is invalid in JSON.
So, it should be use JSON5 instead.

Copy link

@guillermoarellano guillermoarellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AleksanderBodurri
Copy link
Contributor

This is inaccurate. The typescript team does not use JSON5.

See microsoft/TypeScript#12242

@munierujp
Copy link
Author

jsonc?

"angularCompilerOptions": {
  /* ... */
  "debug": true
}

https://code.visualstudio.com/docs/languages/json#_json-with-comments

@AleksanderBodurri
Copy link
Contributor

AleksanderBodurri commented Apr 10, 2020

@munierujp

According to the link you sent jsonc is the schema used for VS code configuration files, nothing to do with typescript.

Further down tsconfig.json is mentioned and it says that the schema to parse it is defined by the VS code extension for typescript.

Regardless, the comment in question is meant more as an indication that you could have more configuration above, not that you must have a comment there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants