Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#45089
Problem
As per the issue k8s minor version 1.30 support needs to be added
Solution
updated all the k8s libraries to kubernetes v1.30.0
other changes done:
updated wrangler from v2 to v3
replaced k8s.io/gengo/examples/set-gen/sets with "k8s.io/apimachinery/pkg/util/sets" since gengo is updated to gengo/v2 in kubernetes v1.30.0 and sets package is removed from gengo/v2 ref
and since gengo args package is also removed in gengo/v2 so removed args.DefaultSourceTree() function uses and added the implementation of that function directly in the code.
similar thing is done in a PR for rancher/norman
apiserver types moved from one dir to another
kubernetes/apiserver@e7eedd1#diff-179ab44de4a16de69e23c8a3fee5a0d6ef22755b90c182744f05ca9e1eca4381
so updated imports in rancher ref
bumped controller-runtime to v0.18.2 and cluster-api to v1.7.2 also updated capi crds and capi webhook yaml files.
updated capi webhooks with custom changes also which is rancher specific change ref
after updating capi crds an error occurred while running rancher
cluster.x-k8s.io/v1alpha3 is deprecated in capi v1.7.2 but it is still in crd. So fixed rancher code to not add deprecated version of a resource from a crd to validate role data. ref
updated python tests test_node_fields and test_dns_fields fix needed because of addition of new fields in k8s v1.30 for these objects.
updated local cluster k3s version to v1.30.0+k3s1 and also updated rancher chart kube-version annotation.
bumped kubernetes libraries to v0.30.1
updated golangci lint to v1.58.1 (was the latest version when i started working on this PR...needs to be bumped to v1.59.0 since it is the latest version).
NOTE: for initial verification used forked dependencies, custom KDM, custom charts repositories and did additional changes needed for these for testing.
Testing
Engineering Testing
Manual Testing
tested v1.30.0 provisioning for all types of cluster.
tested upgrade from 1.29 to 1.30 for all types of cluster.
Automated Testing
Summary: TODO
QA Testing Considerations
Regressions Considerations
TODO
Existing / newly added automated tests that provide evidence there are no regressions: