Data dir rfc #45326
Open
Data dir rfc #45326
+671
−366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakefhyde
force-pushed
the
data-dir-rfc
branch
2 times, most recently
from
cf62507
to
a81637f
Compare
jakefhyde
force-pushed
the
data-dir-rfc
branch
3 times, most recently
from
dcb487a
to
efe766a
Compare
jakefhyde
commented
Jun 4, 2024
|
|
||
| for _, cluster := range provClusters.Items { | ||
| systemAgentDataDir := "" | ||
| for i, e := range cluster.Spec.AgentEnvVars { |
There was a problem hiding this comment.
I think I need to redo this migration for bounds checking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #45038
Problem
Add support for
data-dirconfiguration for RKE2/K3s, CAPR, and the system-agentSolution
Introduce a new field
DataDirectorieson the cluster object for specifying the k8s distro, system agent, and provisioning data directories.Testing
Engineering Testing
Manual Testing
Manually tested both upgrade and fresh cluster provisioning scenarios, writing to folders in
/tmp.Automated Testing
Summary: Update existing unit tests (todo: add more test cases for different data directories)
QA Testing Considerations
Fresh install and upgrade testing for the following cluster configurations (all multinode):
Regressions Considerations
Should test provisioning without specifying fields is unaffected.
Existing / newly added automated tests that provide evidence there are no regressions:
Todo