Bring over BX gas resources #5744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benisgold
reviewed
May 17, 2024
| createQueryKey( | ||
| 'estimateApprovalGasLimitQueryKey', | ||
| { chainId, ownerAddress, assetAddress, spenderAddress, assetType }, | ||
| { persisterVersion: 1 } |
There was a problem hiding this comment.
i'm curious about if/for how long we want to persist/cache this data. can gas limit change based on network congestion?
| // Query Key | ||
|
|
||
| const estimateGasLimitQueryKey = ({ chainId, transactionRequest }: EstimateGasLimitArgs) => | ||
| createQueryKey('estimateGasLimit', { chainId, transactionRequest }, { persisterVersion: 1 }); |
| // Query Key | ||
|
|
||
| const estimateSwapGasLimitQueryKey = ({ chainId, quote, assetToSell, assetToBuy }: EstimateSwapGasLimitArgs) => | ||
| createQueryKey('estimateSwapGasLimit', { chainId, quote, assetToSell, assetToBuy }, { persisterVersion: 1 }); |
There was a problem hiding this comment.
same as above, esp bc quote will for sure change frequently
| }); | ||
|
|
||
| const getMeteorologyNetworkFromChainId = (chainId: ChainId) => { | ||
| switch (chainId) { |
There was a problem hiding this comment.
do we need blast and degen here also
| // /////////////////////////////////////////////// | ||
| // Query Key | ||
|
|
||
| const meteorologyQueryKey = ({ chainId }: MeteorologyArgs) => createQueryKey('meteorology', { chainId }, { persisterVersion: 1 }); |
There was a problem hiding this comment.
same question about persistence
| // Query Key | ||
|
|
||
| const optimismL1SecurityFeeQueryKey = ({ transactionRequest, chainId }: OptimismL1SecurityFeeArgs) => | ||
| createQueryKey('optimismL1SecrityFee', { transactionRequest, chainId }, { persisterVersion: 1 }); |
There was a problem hiding this comment.
same q as above
also nit but the query key is misspelled haha optimismL1SecrityFee -> optimismL1SecurityFee
| // /////////////////////////////////////////////// | ||
| // Query Key | ||
|
|
||
| const providerGasQueryKey = ({ chainId }: ProviderGasArgs) => createQueryKey('providerGas', { chainId }, { persisterVersion: 1 }); |
|
will be splitting this up into separate PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test