Work around onDidCloseTextDocument firing on a wrong document. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes onDidCloseTextDocument seems to get called with a different document (something involving git?). This works around the problem by also watching the list of visible editors, and closing the session. Works around issue rafaelmaiolla#26, related to upstream issue microsoft/vscode#30820.
|
Unfortunately this only works for case one tab has been opened and then closed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes onDidCloseTextDocument seems to get called with a different
document (something involving git?). This works around the problem by
also watching the list of visible editors, and closing the session.
Works around issue #26, related to upstream issue
microsoft/vscode#30820.