Fix circular deps issue #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vladmoroz
commented
May 13, 2024
Comment on lines
+6
to
+12
| 'import/order': [ | ||
| 'error', | ||
| { | ||
| 'newlines-between': 'always', | ||
| groups: [['builtin', 'external'], ['parent', 'sibling', 'index'], 'type'], | ||
| }, | ||
| ], |
There was a problem hiding this comment.
This groups imports and provides a stable order, adds a newline before type imports
vladmoroz
commented
May 13, 2024
Comment on lines
+13
to
+19
| 'import/no-internal-modules': [ | ||
| 'error', | ||
| { | ||
| // Importing from barrel files may lead to circular dependencies within the package. | ||
| forbid: ['helpers/index.js', 'props/index.js'], | ||
| }, | ||
| ], |
There was a problem hiding this comment.
Barrel files caused the circular deps issue
vladmoroz
commented
May 13, 2024
Comment on lines
+20
to
+21
| 'import/consistent-type-specifier-style': ['error', 'prefer-top-level'], | ||
| 'import/newline-after-import': ['error', { count: 1 }], |
There was a problem hiding this comment.
- Enforce "import type { Foo }" instead of "import { type Foo }"
- Just enforcing a newline after imports
benoitgrelard
approved these changes
May 14, 2024
vladmoroz
commented
May 15, 2024
| "lib": ["DOM", "ESNext", "DOM.Iterable"], | ||
| "jsx": "react", | ||
| "declaration": true, | ||
| "emitDeclarationOnly": true, | ||
| "outDir": "dist", | ||
| "strict": true, | ||
| "skipLibCheck": true, | ||
| "esModuleInterop": true | ||
| "esModuleInterop": true, | ||
| "verbatimModuleSyntax": true |
There was a problem hiding this comment.
Enforces the type keyword when importing a type
vladmoroz
commented
May 15, 2024
Comment on lines
+3
to
+4
| "module": "ESNext", | ||
| "moduleResolution": "Node", |
There was a problem hiding this comment.
Was needed to make verbatimModuleSyntax work as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue caused by internal barrel files usage when the Next.js compiler would sometimes fail to compile a project that'd use Radix Themes.
Example for posterity: