Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new theme that mimics maven surefire plugin #147

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

msiemczyk
Copy link

Since the plugin does not provide a way to define the test summary I've
added new themes (maven and maven-plain) and that inherit from
standard and plain themes repsectively but override summaryText to format it the way
maven-surefire(and failsafe)-plugin used to do it maven. I've also
updated unit tests so their passing again and added some new tests for
new classes.

Differences with maven plugin:

  • added the Time Elapsed to "Test Run: " line
  • changed "Results:" to "Summary:" as Gradle build outputs errors before
    Summary (maven includes errors in Results section).

Ideally the plugin provide a way to customize how the summary text looks like, but this will be harder to implement in a generic way that would satisfy everyone needs.

Since the plugin does not provide a way to define the test summary I've
added new themes (maven and maven-parallel) and that inherit from
standard theme but override summaryText to format it the way
maven-surefire(and failsafe)-plugin used to do it maven. I've also
updated unit tests so their passing again and added some new tests for
new classes.

Differences with maven plugin:
- added the Time Elapsed to "Test Run: " line
- changed "Results:" to "Summary:" as Gradle build outputs errors before
Summary (maven includes errors in Results section).
@radarsh
Copy link
Owner

radarsh commented Mar 4, 2020

Hi, this is great - thanks for contributing. Do you have a screenshot handy that shows what the generated output would look like? If not, no worries and I'll check it out later.

@msiemczyk
Copy link
Author

I do. I will provide them in couple minutes.

@msiemczyk
Copy link
Author

Maven theme (colours):

Everything good:
image

Skipped tests:
image

Failed tests (and skipped):
image

Maven plain theme just removes the colours and formatting so we can use that Jenkins console.
image

@msiemczyk
Copy link
Author

@radarsh are you not okay with these changes being made? If not I will have to build custom version of the plugin and deploy to our own local repository so I just need to know if you going to apply these changes to your plugin or not.

@radarsh
Copy link
Owner

radarsh commented Apr 29, 2020

@msiemczyk just held up with a few things. I haven't had a chance to look at this PR in detail yet.

@msiemczyk
Copy link
Author

@radarsh did you have a chance to look at my PR?

@radarsh
Copy link
Owner

radarsh commented May 13, 2020

@msiemczyk I'm sorry but no. You'll hear from me when I have had a look. Appreciate your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants