Remove ingress controller for grafana namespace #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is already a nginx ingress controller running with ingress class nginx. The addition of ingress controller in grafana with the same ingressClass meant that two controllers were racing causing ip flips in ingress address. This patch simply removes the grafana ingress. And since grafana is already using ingressclass of nginx it should still work with the existing ingress controller.
|
This means we will have to do the following. Point the DNS for grafana.sjc3.rackspacecloud.com to the .10 vip on the lb and remove the grafana specific ingress controller. Things should still work. |
|
Does this yank out the grafana dir? Hard to tell here but we probably should if not. Think this LGTM otherwise but would need signoff from the other reviewers. |
|
@sulochan has this been tested? When we deploy grafana in its own namespace, we weren't able to get it to work with the openstack ingress. That is the reason we created the grafana ingress. Phil did point out that there might be an issue with the class name used and maybe we can try fixing that first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is already a nginx ingress controller running with ingress class nginx. The addition of ingress controller in grafana with the same ingressClass meant that two controllers were racing causing ip flips in ingress address.
This patch simply removes the grafana ingress. And since grafana is already using ingressclass of nginx it should still work with the existing ingress controller.