Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated class for WebSocket Errors #941

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Dedicated class for WebSocket Errors #941

wants to merge 3 commits into from

Conversation

tresf
Copy link
Contributor

@tresf tresf commented Mar 17, 2022

Closes #937

Still in draft form, the class is just a proof of concept.

TODO:

  • Return error numbers to JavaScript
    • @bberenz I think I'll need some help with this.
  • Migrate existing errors to only allow new class
  • Add query support for getting an exhaustive listing

@tresf tresf requested a review from akberenz March 17, 2022 20:23
@tresf
Copy link
Contributor Author

tresf commented Mar 26, 2022

@bberenz can you help with the way we're throwing the DeviceException up the stack? The error clearly states that the "USB Device cannot be claimed", which should be reasonable to catch, but instead it throws it all the way up to the socket enum, causing a general error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal for errors to have unique IDs
1 participant