Add JSON as an export option #173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invisal
requested changes
Oct 17, 2023
… for each file type
|
@invisal please help to review it again. |
invisal
requested changes
Oct 25, 2023
Comment on lines
+9
to
+20
| export default function saveStructuredTextFile( | ||
| fileName: string, | ||
| type: SupportedStructuredFileType, | ||
| records: object[] | ||
| ) { | ||
|
|
||
| const serializers = { | ||
| json: jsonSerializer, | ||
| } | ||
|
|
||
| fs.writeFileSync(fileName, serializers[type](records)) | ||
| } |
There was a problem hiding this comment.
This is overkill. We only need a single function that able to write text file.
| @@ -213,6 +222,18 @@ export default function ExportModal({ data, onClose }: ExportModalProps) { | |||
| console.error(e); | |||
| setStage('ERROR'); | |||
| }); | |||
| } else if (format === "json") { | |||
There was a problem hiding this comment.
We can follow this for JSON
We just need to do
jsonString = // can follow the above code;
window.electron.saveTextFile(fileName, jsonString);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will export as an unformatted JSON file using
JSON.stringify(data)