Fix the typescript type declaration #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In typescript (with webpack), a default import doesn't work:
```
import ResizeObserver from 'resize-observer-polyfill';
```
but a star import or an `import = require` import work:
```
import * as ResizeObserver from 'resize-observer-polyfill';
```
or:
```
import ResizeObserver = require('resize-observer-polyfill');
```
This change fixes this issue.
|
We lost an hour to this today |
Sorry, @walkerburgin, seems like this repository is not being maintained... My PR has been left hanging for a long time. We have created a fork in our organization with this fix applied: https://github.com/bettermarks/resize-observer-polyfill |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In typescript (with webpack), a default import doesn't work:
but a star import or an
import = requireimport do work:or:
Apparently there is a closed issue about this. This fixes #24.