Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR-582] Move buffer deletion to a background task #582

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

justjanne
Copy link
Contributor

In Short

  • Adds a background task handler object to each core session
  • Moves buffer deletion to that handler

Impact

Criteria Rank Reason
Impact ★☆☆ 1/3 Prevents the core from timing out while deleting a large buffer
Risk ★★☆ 2/3 Only changes buffer deletion, which is not critical functionality
Intrusiveness ★☆☆ 1/3 Changes localized to a few classes

Rationale

Currently, while deleting buffers, the core may hang and the IRC connection can time out. With the end of freenode this has become a more pressing matter recently. This PR moves deletion of buffers to a thread per-user to prevent users causing a DoS while simultaneously preventing the core from hanging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant