Replace quarkus PGVectorEmbeddingStore with new Langchain4J PGVectorEmbeddingStore #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humcqc
commented
May 23, 2024
| .map(dl -> context.getInjectedReference(AgroalDataSource.class, dl)) | ||
| .orElse(context.getInjectedReference(AgroalDataSource.class, new Default.Literal())); | ||
|
|
||
| dataSource.flush(AgroalDataSource.FlushMode.GRACEFUL); |
There was a problem hiding this comment.
The first build failed, i think it's link to the fact we are using FlushMode.GRACEFUL, perhaps FlushMode.ALL will be better. WDYT ?
|
Thanks for this! I would like to do the update to 0.31 in #622, so once that is in, please rebase this PR onto it. |
|
#622 has been merged |
geoand
changed the title
|
Please rebase the PR onto the latest Thanks |
humcqc
changed the title
humcqc
changed the title
humcqc
changed the title
geoand
changed the title
|
Sorry for the delay, traveling all week, but I'll give it a shot as soon as I can |
jmartisk
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace quarkus PGVectorEmbeddingStore with new Langchain4J PGVectorEmbeddingStore
Allow metadata filtering and remove features
@jmartisk @sebastienblanc @geoand @langchain4j this PR replaces #410