Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolution for Not able to override step.provider.pkg property for data driven scenario #155

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

infoneershalin
Copy link

@infoneershalin infoneershalin commented Nov 28, 2017

resolution for #154

we were using initStep only when step is not yet initiated.
we need to re init the step in case fileName is different as step.provider.pkg has changed

@infoneershalin
Copy link
Author

Will add Unit Testcases soon.

Copy link
Author

@infoneershalin infoneershalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjayswal please review this Pull request

@infoneershalin infoneershalin changed the title resolution for #154 resolution for Not able to override step.provider.pkg property for data driven scenario Nov 28, 2017
@cjayswal
Copy link
Member

Did you understand the issue? Please share the test case. I am afraid that solution will have impact on performance.

@infoneershalin
Copy link
Author

infoneershalin commented Nov 28, 2017

Yes, DataDrivenScenario.java creates proxy steps and pass it to execute method of Scenario.java
As proxy steps are already initiated before any step executed, the change in step.provider.pkg property by subsequent step does not get reflected.
Where as for non DataDrivenScenario steps get initiated one by one and hence change in step.provider.pkg get reflected properly
attaching TestProject_ISSUE_154.zip here

@cjayswal
Copy link
Member

You can check by commenting step initialization to have lazy initialization in DD scenario

@infoneershalin
Copy link
Author

infoneershalin commented Nov 28, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants