fix: add missing fields to package-lock.json and bump version #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: I am packaging
qdrant-web-uifor Nixpkgs.Problem: some dependencies in our
package-lock.jsonlack of theresolvedandintegrityfields. This is probably caused by a bug in npm (npm/cli#4263, npm/cli#6301). Nix (and probably other sandboxed builders without internet access) relies on these fields for fetching/caching the dependencies.The solution in this PR: run npm-lockfile-fix to add missing fields.
Possible alternative solution: delete
package-lock.jsonand regenerate it from scratch, as proposed by this comment. The drawback is that it will bump a lot of dependencies versions. Not sure if we want to do this right now.Other changes in this PR:
npm audit fixto avoid CI failing, see the log.