Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add notifications for issues. #183

Merged
merged 10 commits into from
May 25, 2024
Merged

feat: Add notifications for issues. #183

merged 10 commits into from
May 25, 2024

Conversation

kartik-gupta-ij
Copy link
Member

@kartik-gupta-ij kartik-gupta-ij commented May 20, 2024 •
edited
Loading

UI for qdrant/qdrant#3471

Layout section

  • Notification for error(issues) with count.

Modal to view issues.

  • Layout of modal
  • Action button

@kartik-gupta-ij kartik-gupta-ij marked this pull request as draft May 20, 2024 16:07
generall
generall reviewed May 20, 2024
View reviewed changes
src/pages/Home.jsx Outdated
React.useEffect(() => {
const interval = setInterval(() => {
getIssuesCount();
console.log('This will run every 5 seconds!', issuses);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need it every 5 seconds. Let's maybe keep it to only once on the page load

@kartik-gupta-ij kartik-gupta-ij marked this pull request as ready for review May 22, 2024 01:31
@kartik-gupta-ij kartik-gupta-ij marked this pull request as draft May 22, 2024 01:34
kartik-gupta-ij
kartik-gupta-ij commented May 22, 2024
View reviewed changes
Copy link
Member Author

@kartik-gupta-ij kartik-gupta-ij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2024-05-22.at.7.00.24.AM.mov

@generall, @coszio Please review!

@kartik-gupta-ij kartik-gupta-ij marked this pull request as ready for review May 22, 2024 01:57
@timvisee
Copy link
Member

@kartik-gupta-ij That looks fantastic!

I do think I prefer a overlaying sidebar, just like the green commands button on the bottom left. It has more room for issues, and keeps the UI consistent. Wdyt?

And we should probably render the request result a bit better, but I don't have a direct suggestion there.

coszio
coszio reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@coszio coszio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love seeing the actual request in the button to solve.

However, I agree with @timvisee. Creating an index is an important choice, so it would be more fitting to have a dedicated page for this.

For the content of the notification. The title should be more friendly. This can be extracted from the ID, up to the first / (slash). Otherwise I can include this as an additional field in GET /issues

kartik-gupta-ij
kartik-gupta-ij commented May 23, 2024
View reviewed changes
Copy link
Member Author

@kartik-gupta-ij kartik-gupta-ij left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2024-05-23.at.8.10.55.PM.mov

Feedbacks @timvisee , @coszio ?

@coszio
Copy link
Contributor

coszio commented May 23, 2024

The displaying of issues is looking better 👍

Another reason for having a dedicated page is that sometimes it is helpful to clear the issues with a button that calls DELETE /issues. Use-case: just playing around / developing with filters, so that using a wrong key name will trigger the issue for it, and it doesn't mean that an index should be created.

@generall generall merged commit a124a11 into master May 25, 2024
1 check passed
timonv pushed a commit to bosun-ai/swiftide that referenced this pull request Jun 28, 2024
@renovate
chore(deps): update qdrant/qdrant docker tag to v1.9.7 (#95)
8a2541e 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [qdrant/qdrant](https://qdrant.com/)
([source](https://togithub.com/qdrant/qdrant)) | service | patch |
`v1.9.2` -> `v1.9.7` |

---

### Release Notes

<details>
<summary>qdrant/qdrant (qdrant/qdrant)</summary>

### [`v1.9.7`](https://togithub.com/qdrant/qdrant/releases/tag/v1.9.7)

[Compare
Source](https://togithub.com/qdrant/qdrant/compare/v1.9.6...v1.9.7)

### Change log

#### Improvements

-
[qdrant/qdrant#4517
- Do not allow embedding the web UI in an iframe
-
[qdrant/qdrant#4556
- Include HNSW configuration in snasphots to fix some edge cases

#### Bug fixes

-
[qdrant/qdrant#4555
- Fix panic on start with sparse index from versions 1.9.3 to 1.9.6
-
[qdrant/qdrant#4551
- Fix positive/negative points IDs being excluded when using
recommendation search with `lookup_from`

### [`v1.9.6`](https://togithub.com/qdrant/qdrant/releases/tag/v1.9.6)

[Compare
Source](https://togithub.com/qdrant/qdrant/compare/v1.9.5...v1.9.6)

### Change log

#### Bug fixes

-
[qdrant/qdrant#4472
- fix potential panic on recovery sparse vectors from crash
-
[qdrant/qdrant#4426
- improve error message on missing payload index
-
[qdrant/qdrant#4375
- fix in-place updates for sparse index
-
[qdrant/qdrant#4523
- fix missing payload index issue, introduced in v1.9.5

### [`v1.9.5`](https://togithub.com/qdrant/qdrant/releases/tag/v1.9.5)

[Compare
Source](https://togithub.com/qdrant/qdrant/compare/v1.9.4...v1.9.5)

### Change log

#### Features

-
[qdrant/qdrant#4254
- Add pyroscope integration for continuous profiling on demand

#### Improvements

-
[qdrant/qdrant#4309
- Allow to configure default number of shards per node
-
[qdrant/qdrant#4317
- Allow to overwrite optimizer settings via config
-
[qdrant/qdrant#4312,
[qdrant/qdrant#4369
- Improve vector size estimations, making index thresholds more reliable
-
[qdrant/qdrant#4428
- Improve default maximum segment size, base it on number of CPUs used
for indexing
-
[qdrant/qdrant#4370
- Use consistent RocksDB settings for both put and remove
-
[qdrant/qdrant#4376
- Improve ordering of insertions and deletions in RocksDB
-
[qdrant/qdrant#4371
- Log error if segment flushing failed on drop
-
[qdrant/qdrant#4352
- Promote REST request processing problems from warning to error
-
[qdrant/qdrant#4368
- Improve error messages in cases of missing vectors
-
[qdrant/qdrant#4391
- Improve shard state log message, not strictly related to snapshot
recovery
-
[qdrant/qdrant#4414
- Improve Dockerfile, don't invalidate caches each commit and allow
debug settings

#### Bug fixes

-
[qdrant/qdrant#4402
- Fix deadlock caused by concurrent snapshot and optimization
-
[qdrant/qdrant#4411
- Fix potentially losing vectors on crash by enabling RocksDB WAL
-
[qdrant/qdrant#4416,
[qdrant/qdrant#4440
- Respect `max_segment_size` on data ingestion with optimizers disabled,
create segments as needed
-
[qdrant/qdrant#4442
- Fix potentially having bad HNSW links on multithreaded systems

### [`v1.9.4`](https://togithub.com/qdrant/qdrant/releases/tag/v1.9.4)

[Compare
Source](https://togithub.com/qdrant/qdrant/compare/v1.9.3...v1.9.4)

### Change log

#### Bug fixes

-
[qdrant/qdrant#4332
- Fix potentially losing a segment when creating a snapshot with ongoing
updates
-
[qdrant/qdrant#4342
- Fix potential panic on start if there is no appendable segment
-
[qdrant/qdrant#4328
- Prevent panic when searching with huge limit

### [`v1.9.3`](https://togithub.com/qdrant/qdrant/releases/tag/v1.9.3)

[Compare
Source](https://togithub.com/qdrant/qdrant/compare/v1.9.2...v1.9.3)

### Change log

#### Improvements

-
[qdrant/qdrant#4165
- Handle Out-Of-Disk on insertions gracefully
-
[qdrant/qdrant#3964
- Faster consensus convergence with batched updates
-
[qdrant/qdrant#4301
- Deduplicate points by ID for custom sharding

#### Bug fixes

-
[qdrant/qdrant#4307
- Fix overflow panic if scroll limit is usize::MAX
-
[qdrant/qdrant#4322
- Fix panic with missing sparse vectors after recovery of corrupted
storage

#### Web UI

-
[qdrant/qdrant-web-ui#183
- Notification for miss-configured collections

Full change log:
https://github.com/qdrant/qdrant-web-ui/releases/tag/v0.1.26

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/bosun-ai/swiftide).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coszio coszio coszio left review comments

@generall generall generall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kartik-gupta-ij @timvisee @coszio @generall