Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: Restore previously used tab on load #20705

Merged
merged 4 commits into from
May 27, 2024

Conversation

Piccirello
Copy link
Member

@Piccirello Piccirello commented Apr 15, 2024

This PR restores the users previously used tab (Transfer, Search, RSS, etc.) when the Web UI is reloaded.

Screen.Recording.2024-04-14.at.23.33.19.mov

@Piccirello Piccirello added the WebUI WebUI-related issues/changes label Apr 15, 2024
@Piccirello Piccirello added this to the 5.0 milestone Apr 15, 2024
@Piccirello Piccirello requested a review from a team April 15, 2024 06:35
@Piccirello Piccirello marked this pull request as ready for review April 15, 2024 06:37
src/webui/www/private/scripts/client.js Outdated Show resolved Hide resolved
src/webui/www/private/scripts/client.js Show resolved Hide resolved
src/webui/www/private/scripts/client.js Outdated Show resolved Hide resolved
This simplifies development as developers can now directly set breakpoints in the browser on search code.
The log panel may be displayed before its JS has loaded, which results in an error. This prevents the error by delaying initialization until the necessary scripts are loaded.
Chocobo1
Chocobo1 previously approved these changes May 7, 2024
This logic bug prevented the double click handler from being readded to rows once the search completed.
@Piccirello
Copy link
Member Author

@Chocobo1 is this ready to merge? I see that it's approved.

@Chocobo1 Chocobo1 merged commit 6d07377 into qbittorrent:master May 27, 2024
10 of 14 checks passed
@Piccirello Piccirello deleted the restore-tab branch June 11, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants