This repository has been archived by the owner on Feb 12, 2023. It is now read-only.
WIP Friend blocking #6623
Draft
WIP Friend blocking #6623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with default constructors
So that chat can be shown for contacts that were removed from toxcore.
For blocked friends that don't exist in toxcore.
Since they aren't stored in toxcore.
Split friend name and status settings to be reused for blocked friends which load them from settings.
* architecturally, reusing ChatForm is racy. It calls getId on Friend in many places, and although the UI is disabled when the friend becomes blocked, if ChatForm is still processing an action then calls getId to call down to core, that asserts. Additionally Core might have been told to remove the friend by the time ChatForm calls down. The typing timer in ChatForm has a much larger race, since it gives many seconds to cause the issue. * Normally Core outlives ChatForm entirely, since it's made by Profile which outlives all of Widget. So this is a new architectual problem that Core (effectively) can go away while ChatForm doesn't.
* filtering by blocked * some widget cleanup * groupchatform support
Codecov Report
@@ Coverage Diff @@
## master #6623 +/- ##
==========================================
- Coverage 11.75% 11.66% -0.10%
==========================================
Files 303 303
Lines 20582 20796 +214
==========================================
+ Hits 2419 2425 +6
- Misses 18163 18371 +208
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
This change is