chore(build): build windows spellcheck deps #5319
Conversation
anthonybilinski
force-pushed
the
windows_spellcheck_deps
branch
4 times, most recently
from
700375f
to
960e9ca
Compare
anthonybilinski
force-pushed
the
windows_spellcheck_deps
branch
5 times, most recently
from
d9fdab6
to
752b92d
Compare
anthonybilinski
force-pushed
the
windows_spellcheck_deps
branch
7 times, most recently
from
a6c1664
to
6f0cd58
Compare
|
This should now be working and loaded by qTox. There's the problem of needing dictionaries for each language supported, I'm not sure what the best way to support this on Windows is. On Linux, there are system-wide dictionaries available for each language, and any installed will be available to applications. On Windows, I guess we just pick the most popular languages and bundle those with the install, and if someone's personal language isn't there they have to manually install a file a drop it in the directory? |
anthonybilinski
changed the title
anthonybilinski
force-pushed
the
windows_spellcheck_deps
branch
from
6f0cd58
to
53152a5
Compare
anthonybilinski
force-pushed
the
windows_spellcheck_deps
branch
4 times, most recently
from
a44cea4
to
35d2cc5
Compare
anthonybilinski
force-pushed
the
windows_spellcheck_deps
branch
from
35d2cc5
to
c14e578
Compare
|
I've got an English only dictionary packaged now and Sonnet working well on Windows IFF Hunspell is built with debug symbols, if I build Hunspell without debug symbols, it crashes when attempting to load the dict. I've created an issue with Hunspell to see if I can get some help figuring out what's going on: hunspell/hunspell#627 |
anthonybilinski
force-pushed
the
windows_spellcheck_deps
branch
from
c14e578
to
980f469
Compare
anthonybilinski
force-pushed
the
windows_spellcheck_deps
branch
3 times, most recently
from
dfdfc4d
to
921af94
Compare
anthonybilinski
force-pushed
the
windows_spellcheck_deps
branch
from
921af94
to
68abbfc
Compare
TODO: check if this fixes the crash on dictionary open
anthonybilinski
force-pushed
the
windows_spellcheck_deps
branch
from
18c4b03
to
d8bad48
Compare
|
Hunspell has since released version 1.7.0. I updated this PR to include that version - I'll check soon if this fixes the crash on dictionary load. |
|
Sonnet doesn't find hunspell anymore once hunspell's updated to 1.7.0, even after sonnet it upgraded to the latest version available at https://download.kde.org/stable/frameworks, 5.62 (5.63 gives a http 503). The reason it can't find it is probably because of https://github.com/KDE/sonnet/blob/852f24888d09af0b80770f4f80e06b559369e6d3/cmake/FindHUNSPELL.cmake#L43, and hunspell is only installing |
|
Patching sonnet to find hunspell 1.7.0 works, and it continues to run correctly when hunspell is built with debug flags, but continues to crash on dictionary load when build without debug flags :( Basically no change from a year ago, and no response on the hunspell ticket. I guess I'll work on building aspell as the backend for sonnet. |
This change is