Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various issues in unstable CI #2784

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Apr 19, 2024

cftime's master branch should support numpy 2 now, but from what I could tell our CI still wasn't working. My best guess is the conda-installed version is getting used before the pip one. This PR first removes the conda installed one in unstable CI before installing from source.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@djhoese djhoese added the cleanup Code cleanup but otherwise no change in functionality label Apr 19, 2024
@djhoese djhoese requested a review from mraspaud as a code owner April 19, 2024 14:14
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (4faccbb) to head (82899d9).
Report is 50 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2784      +/-   ##
==========================================
+ Coverage   95.93%   95.94%   +0.01%     
==========================================
  Files         377      379       +2     
  Lines       53541    53673     +132     
==========================================
+ Hits        51362    51494     +132     
  Misses       2179     2179              
Flag Coverage Δ
behaviourtests 4.09% <ø> (-0.02%) ⬇️
unittests 96.03% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Apr 19, 2024

Pull Request Test Coverage Report for Build 8756273146

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 8732515933: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@djhoese
Copy link
Member Author

djhoese commented Apr 19, 2024

@mraspaud Ok I've got CI working in unstable as far as numpy 2 goes and what we have control over. The remaining things are:

  1. The xarray dtype/scalar handling that I have a PR for in xarray.
  2. Things based on numba fail since numba does not support numpy 2 yet.

I think this is ready for merge.

@djhoese djhoese changed the title Fix cftime not being uninstalled in unstable CI Fix various issues in unstable CI Apr 20, 2024
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud added this to the v0.49.0 milestone Jun 4, 2024
@mraspaud mraspaud merged commit 1c921ba into pytroll:main Jun 4, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup but otherwise no change in functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants