Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Sentinel-2 MSI L2A SAFE datasets #2783

Open
wants to merge 44 commits into
base: main
Choose a base branch
from

Conversation

yukaribbba
Copy link
Contributor

@yukaribbba yukaribbba commented Apr 18, 2024

Add support for Sentinel-2 MSI L2A SAFE datasets

  • Tests added
  • Fully documented

Composites family:
image
image
image

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.97%. Comparing base (3b9c04e) to head (18231e4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2783      +/-   ##
==========================================
+ Coverage   95.95%   95.97%   +0.01%     
==========================================
  Files         379      379              
  Lines       53888    53920      +32     
==========================================
+ Hits        51708    51748      +40     
+ Misses       2180     2172       -8     
Flag Coverage Δ
behaviourtests 4.08% <0.00%> (-0.01%) ⬇️
unittests 96.06% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Apr 18, 2024

Pull Request Test Coverage Report for Build 9171397952

Details

  • 101 of 101 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 96.05%

Files with Coverage Reduction New Missed Lines %
satpy/readers/msi_safe.py 1 98.26%
Totals Coverage Status
Change from base Build 9157044280: 0.02%
Covered Lines: 51620
Relevant Lines: 53743

💛 - Coveralls

@simonrp84
Copy link
Member

Thanks for adding this, it was on my to-do list but you got there first :-)

@yukaribbba
Copy link
Contributor Author

Thanks for adding this, it was on my to-do list but you got there first :-)

🍺

@yukaribbba
Copy link
Contributor Author

pre-commit.ci autofix

@yukaribbba
Copy link
Contributor Author

pre-commit.ci autofix

@yukaribbba
Copy link
Contributor Author

pre-commit.ci autofix

@yukaribbba yukaribbba marked this pull request as ready for review April 21, 2024 13:09
@yukaribbba
Copy link
Contributor Author

@simonrp84 If you got time pls also take a look. :D

@mraspaud
Copy link
Member

Thanks a lot for this new reader functionality @yukaribbba !
One general comment before I dive deeper into this, could you make this a separate yaml file for this reader? The python code can stay with the l1 reader, but it will be easier to have a separate yaml file as this will make it effectively separate from the l1 reader for the user.

@yukaribbba
Copy link
Contributor Author

Sure!

@yukaribbba
Copy link
Contributor Author

The two YAMLs are separated now.

@yukaribbba
Copy link
Contributor Author

@mraspaud Could you take some time to review this?

@mraspaud
Copy link
Member

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants