Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compiled optimizer + lr scheduler tutorial #2874

Merged
merged 17 commits into from
May 21, 2024

Conversation

mlazos
Copy link
Contributor

@mlazos mlazos commented May 17, 2024

Adding a tutorial demonstrating how to compose the LRScheduler with a compiled optimizer

@mlazos mlazos requested a review from svekars May 17, 2024 00:49
Copy link

pytorch-bot bot commented May 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2874

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 56c0b83 with merge base f66b5b2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some editorial suggestions. Thank you!

recipes_source/compiling_optimizer_lr_scheduler.rst Outdated Show resolved Hide resolved
recipes_source/compiling_optimizer_lr_scheduler.rst Outdated Show resolved Hide resolved
recipes_source/compiling_optimizer_lr_scheduler.rst Outdated Show resolved Hide resolved
recipes_source/compiling_optimizer_lr_scheduler.rst Outdated Show resolved Hide resolved
recipes_source/compiling_optimizer_lr_scheduler.rst Outdated Show resolved Hide resolved
recipes_source/compiling_optimizer_lr_scheduler.rst Outdated Show resolved Hide resolved
recipes_source/compiling_optimizer_lr_scheduler.rst Outdated Show resolved Hide resolved
Co-authored-by: Svetlana Karslioglu <[email protected]>
Copy link
Member

@williamwen42 williamwen42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you have a .py version up for next release?

recipes_source/compiling_optimizer_lr_scheduler.rst Outdated Show resolved Hide resolved
@mlazos
Copy link
Contributor Author

mlazos commented May 17, 2024

Will you have a .py version up for next release?

I want to, but last time we did this we had a strange issue in the docs CI due to a previous test modifying the decomps and causing it to fail, so I went with RST both with this and the previous compiled optimizer tutorial.

@mlazos
Copy link
Contributor Author

mlazos commented May 17, 2024

Will you have a .py version up for next release?

I want to, but last time we did this we had a strange issue in the docs CI due to a previous test modifying the decomps and causing it to fail, so I went with RST both with this and the previous compiled optimizer tutorial.

Talked to svetlana offline, this should be possible

Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the build isn't passing, but contentwise this LGTM

recipes_source/compiling_optimizer_lr_scheduler.py Outdated Show resolved Hide resolved
recipes_source/compiling_optimizer_lr_scheduler.py Outdated Show resolved Hide resolved
@svekars svekars merged commit 98221cc into main May 21, 2024
17 checks passed
@svekars svekars deleted the mlazos/compiled-opt-lr-sched branch May 21, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants