-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compiled optimizer + lr scheduler tutorial #2874
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2874
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 56c0b83 with merge base f66b5b2 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some editorial suggestions. Thank you!
Co-authored-by: Svetlana Karslioglu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you have a .py
version up for next release?
I want to, but last time we did this we had a strange issue in the docs CI due to a previous test modifying the decomps and causing it to fail, so I went with RST both with this and the previous compiled optimizer tutorial. |
Talked to svetlana offline, this should be possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the build isn't passing, but contentwise this LGTM
Adding a tutorial demonstrating how to compose the LRScheduler with a compiled optimizer