edited cifar10_tutorial.py #2604
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2604
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @svekars, |
There was a problem hiding this comment.
Please restrict your PR to one fix at the time and perhaps add before and after picture
For example https://pytorch.org/tutorials/beginner/blitz/cifar10_tutorial.html already renders pictures correctly and links are already clickable, so I'm a bit confused why change to the link formatting/ image rendering are necessary
| @@ -32,8 +31,7 @@ | |||
| ‘dog’, ‘frog’, ‘horse’, ‘ship’, ‘truck’. The images in CIFAR-10 are of | |||
| size 3x32x32, i.e. 3-channel color images of 32x32 pixels in size. | |||
|
|
|||
| .. figure:: /_static/img/cifar10.png | |||
| :alt: cifar10 | |||
|  | |||
There was a problem hiding this comment.
Why this is needed? (I.e. keeping it as is allows one to re-host the repository anywhere they want, isn't it?)
|
Sorry I will keep that in mind for next issue. I was referring to the colab file the image isnt rendering correctly and all the link are unclickable in the colab https://colab.research.google.com/github/pytorch/tutorials/blob/gh-pages/_downloads/cifar10_tutorial.ipynb#scrollTo=N1BibYLW8C4N . |
|
@anikethc at the very least, .py files should remain valid executable files, which is not the case after your changes, is it? |
|
Everything was working fine when I executed the ipynb in the google colab https://colab.research.google.com/drive/1GOhFgmRs-nMF9W7eJjcmBahk6SbBJLXS?usp=sharing maybe something went wrong when I converted it into .py file. I will look into it. Thank you for being patient with me. |
|
Hi @malfet , Could you please review the commit. |
There was a problem hiding this comment.
Can you please restrict this PR to just making blogs non-executable?
I.e. the convention throughout the tutorials are to use rst markup convention, not HTML one, which makes lots of <IMG and <A HREF changes wrong. I understand that they do not render in the collab notebook correctly, but this probably tells something about converter pipeline
Fixes #792
Description
I've set the code blocks to be non-executable. However, the sections titled "2. Define a Convolution Neural Network" and "3. Define a Loss function and optimizer" should retain their executability to ensure error-free execution. I've also cleaned up the code by removing extraneous symbols , fixed the imaged which was not being rendered correctly and made the links clickable.