feat: add privileged option to local_docker (#897) #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
For your consideration, @kiukchung |
|
Any chance you can check this request, @d4l3k? |
|
Any chance you can look at this one, @andywag? |
d4l3k
reviewed
May 29, 2024
|
Also not sure why it's not giving me an option to run the full tests -- maybe need to bump the PR. @clumsy sorry for the delay in reviews on this |
|
No worries, @d4l3k. Should I force push an amended commit to trigger rebuild? |
clumsy
force-pushed
the
feat/local_docker_privileged
branch
from
bb7c6cb
to
ec8be03
Compare
|
Addressed your comment, @d4l3k. Please let me know if further modifications are needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
privilegedoption forlocal_dockerso that the container can start in privileged mode, same way we can do this foraws_batchscheduler. Defaults toFalse, same as inaws_batch.Test plan:
☑ unit test added
☑ tested locally: