torchx: add metadata_urls to allow printing user links from the CLI #532
Conversation
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D37353646 |
…ytorch#532) Summary: Pull Request resolved: pytorch#532 This adds a new `metadata_urls` to AppStatus and `metadata` to DescribeAppResponse. Metadata URLs are automatically returned from metadata values if they start with `http://` or `https://`. This isn't quite as clean as a dedicated URLs field that we discussed in pytorch#509 but can work when calling status and not just during launch time. This also enables a way for schedulers to return extra UI links and services that are scheduler specific but not available at launch time. Differential Revision: D37353646 fbshipit-source-id: dfe629bf75b489a9c842d1bb1d45d0edaf9ce7f0
|
This pull request was exported from Phabricator. Differential Revision: D37353646 |
Codecov Report
@@ Coverage Diff @@
## main #532 +/- ##
==========================================
- Coverage 94.75% 94.74% -0.02%
==========================================
Files 65 65
Lines 3949 3956 +7
==========================================
+ Hits 3742 3748 +6
- Misses 207 208 +1
Continue to review full report at Codecov.
|
|
Hi @d4l3k! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Summary:
This adds a new
metadata_urlsto AppStatus andmetadatato DescribeAppResponse. Metadata URLs are automatically returned from metadata values if they start withhttp://orhttps://. This isn't quite as clean as a dedicated URLs field that we discussed in #509 but can work when calling status and not just during launch time.This also enables a way for schedulers to return extra UI links and services that are scheduler specific but not available at launch time.
Differential Revision: D37353646