Introduce use_sync_collectives configuration #2010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57442917 |
IvanKobzarev
pushed a commit
to IvanKobzarev/torchrec
that referenced
this pull request
May 16, 2024
Summary: Introduce use_sync_collectives global config similar to gradient_division. Remove is_torchdynamo_compiling, new config will control that. test_pt2_multiprocess needs this setting for compilation Differential Revision: D57442917
IvanKobzarev
force-pushed
the
export-D57442917
branch
from
84dea0b
to
3cbb142
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57442917 |
IvanKobzarev
pushed a commit
to IvanKobzarev/torchrec
that referenced
this pull request
May 16, 2024
Summary: Introduce use_sync_collectives global config similar to gradient_division. Remove is_torchdynamo_compiling, new config will control that. test_pt2_multiprocess needs this setting for compilation Differential Revision: D57442917
IvanKobzarev
force-pushed
the
export-D57442917
branch
from
3cbb142
to
8166b15
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57442917 |
IvanKobzarev
pushed a commit
to IvanKobzarev/torchrec
that referenced
this pull request
May 16, 2024
Summary: Introduce use_sync_collectives global config similar to gradient_division. Remove is_torchdynamo_compiling, new config will control that. test_pt2_multiprocess needs this setting for compilation Differential Revision: D57442917
IvanKobzarev
force-pushed
the
export-D57442917
branch
from
8166b15
to
bce7697
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57442917 |
IvanKobzarev
pushed a commit
to IvanKobzarev/torchrec
that referenced
this pull request
May 16, 2024
Summary: Introduce use_sync_collectives global config similar to gradient_division. Replace is_torchdynamo_compiling to use from pt2/checks test_pt2_multiprocess needs this setting for compilation. Reviewed By: dstaay-fb, gnahzg Differential Revision: D57442917
IvanKobzarev
force-pushed
the
export-D57442917
branch
from
bce7697
to
9c0cc5c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57442917 |
Summary: Introduce use_sync_collectives global config similar to gradient_division. Replace is_torchdynamo_compiling to use from pt2/checks test_pt2_multiprocess needs this setting for compilation. Reviewed By: dstaay-fb, gnahzg Differential Revision: D57442917
IvanKobzarev
force-pushed
the
export-D57442917
branch
from
9c0cc5c
to
d9c56e3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57442917 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Introduce use_sync_collectives global config similar to gradient_division.
Remove is_torchdynamo_compiling, new config will control that.
test_pt2_multiprocess needs this setting for compilation
Differential Revision: D57442917