One table per TBE mode will NOT separate multiple shards within the same table #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame table Summary: In the past, we assign UUID per each `ShardedEmbeddingTable` to ensure they're grouped into separate TBEs accordingly. However, we observed that it's possible for some tables (especially for VLE) to be have multiple shards of a table in the same rank, in this case, having them in different TBE will cause issue (see test plan). This diff ensure multiple shards of a same table (sharing the same name) to be grouped into one TBE. Differential Revision: D55671831
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55671831 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In the past, we assign UUID per each
ShardedEmbeddingTableto ensure they're grouped into separate TBEs accordingly. However, we observed that it's possible for some tables (especially for VLE) to be have multiple shards of a table in the same rank, in this case, having them in different TBE will cause issue (see test plan).This diff ensure multiple shards of a same table (sharing the same name) to be grouped into one TBE.
Differential Revision: D55671831