Remove extremely slow logic from RequestOnlySplitEmbeddingBagCollectionsSparseArch #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57290467 |
…onsSparseArch Summary: RequestOnlySplitEmbeddingBagCollectionsSparseArch currently does a regroup logic which is extremely slow and introduces a bunch of unnecessary torch.cats into the graph. Furthermore, uses of the output of RequestOnlySplitEmbeddingBagCollectionsSparseArch calls regroup_as_dict on the KeyedTensors anyways: https://fburl.com/code/fsbptq4g. Here, we optimize it and ensure regroup_as_dict can handle same key across KTs. This should have no production impact on the APS side as no models are currently using RequestOnlySplitEmbeddingBagCollectionsSparseArch for inference. Differential Revision: D57290467
PaulZhang12
force-pushed
the
export-D57290467
branch
from
c923c6e
to
f1f9542
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57290467 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D57290467