Move eager model processing functions to torchrec/inference #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
PaulZhang12
force-pushed
the
export-D56728862
branch
from
02831c6
to
a996598
Compare
Summary: Moves quantize and shard methods from aps_predict_factory_input_trec_sharding_format.py inside torchrec/inference. This resolves dependency issues from multiple places depending on this API for eager model processing (AIMP FX, AIMP PT2, unit tests, etc.) Along with this change, compute device is now CUDA to correctly capture device propagation for eventually placing remote and merge on CUDA device Reviewed By: ZhengkaiZ Differential Revision: D56728862
PaulZhang12
force-pushed
the
export-D56728862
branch
from
a996598
to
6fc93b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D56728862