Enable AOTI shim v2 build and add into libtorch #125211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125211
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ae214cc with merge base e0d2c24 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary: Follow up of pytorch#125087 This diff will create shim v2 header and cpp file and corresponding build Differential Revision: D56617546
hl475
changed the title
hl475
requested review from
linbinyu,
desertfire and
frank-wei
and removed request for
linbinyu
|
put this on hold due to the extra comment in #120513 |
|
As we discussed offline, #125589 switched to generate only .cpp files at the build time. Header files are stored in PyTorch repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Follow up of #125087
This diff will create shim v2 header and cpp file and corresponding build
Differential Revision: D56617546