Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inductor][Quant] Fix PT2E Dynamic Quant regression #125207

Commits on Apr 30, 2024

  1. Fix PT2E Dynamic Quant regression

    [ghstack-poisoned]
    leslie-fang-intel committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b119c1b View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Update on "[Inductor][Quant] Fix PT2E Dynamic Quant regression"

    **Summary**
    Fix 2 regression issues caused by previous refactor:
    
    - Fix the issue in dequant promotion pass with dynamic quant when the dequant node is with `tensor` overload.
    - Fix numerical issue in dynamic quant, since input will convert to scales' dtype (which is `double`) to do quant operatoration with previous implementation.
    
    **TestPlan**
    ```
    clear && python -u -m pytest -s -v test/inductor/test_mkldnn_pattern_matcher.py -k test_dynamic_qlinear_input_dim_exceeds_2
    clear && python -u -m pytest -s -v test/inductor/test_mkldnn_pattern_matcher.py -k test_qlinear_dequant_promotion_dynamic_cpu
    ```
    
    cc ezyang msaroufim bdhirsh anijain2305 chauhang voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire
    
    [ghstack-poisoned]
    leslie-fang-intel committed May 6, 2024
    Configuration menu
    Copy the full SHA
    e2840e2 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Update on "[Inductor][Quant] Fix PT2E Dynamic Quant regression"

    **Summary**
    Fix 2 regression issues caused by previous refactor:
    
    - Fix the issue in dequant promotion pass with dynamic quant when the dequant node is with `tensor` overload.
    - Fix numerical issue in dynamic quant, since input will convert to scales' dtype (which is `double`) to do quant operatoration with previous implementation.
    
    **TestPlan**
    ```
    clear && python -u -m pytest -s -v test/inductor/test_mkldnn_pattern_matcher.py -k test_dynamic_qlinear_input_dim_exceeds_2
    clear && python -u -m pytest -s -v test/inductor/test_mkldnn_pattern_matcher.py -k test_qlinear_dequant_promotion_dynamic_cpu
    ```
    
    cc ezyang msaroufim bdhirsh anijain2305 chauhang voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire
    
    [ghstack-poisoned]
    leslie-fang-intel committed May 7, 2024
    Configuration menu
    Copy the full SHA
    b196575 View commit details
    Browse the repository at this point in the history
  2. Update on "[Inductor][Quant] Fix PT2E Dynamic Quant regression"

    **Summary**
    Fix 2 regression issues caused by previous refactor:
    
    - Fix the issue in dequant promotion pass with dynamic quant when the dequant node is with `tensor` overload.
    - Fix numerical issue in dynamic quant, since input will convert to scales' dtype (which is `double`) to do quant operatoration with previous implementation.
    
    **TestPlan**
    ```
    clear && python -u -m pytest -s -v test/inductor/test_mkldnn_pattern_matcher.py -k test_dynamic_qlinear_input_dim_exceeds_2
    clear && python -u -m pytest -s -v test/inductor/test_mkldnn_pattern_matcher.py -k test_qlinear_dequant_promotion_dynamic_cpu
    ```
    
    cc ezyang msaroufim bdhirsh anijain2305 chauhang voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire
    
    [ghstack-poisoned]
    leslie-fang-intel committed May 7, 2024
    Configuration menu
    Copy the full SHA
    3fbabb3 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Update on "[Inductor][Quant] Fix PT2E Dynamic Quant regression"

    **Summary**
    Fix 2 regression issues caused by previous refactor:
    
    - Fix the issue in dequant promotion pass with dynamic quant when the dequant node is with `tensor` overload.
    - Fix numerical issue in dynamic quant, since input will convert to scales' dtype (which is `double`) to do quant operatoration with previous implementation.
    
    **TestPlan**
    ```
    clear && python -u -m pytest -s -v test/inductor/test_mkldnn_pattern_matcher.py -k test_dynamic_qlinear_input_dim_exceeds_2
    clear && python -u -m pytest -s -v test/inductor/test_mkldnn_pattern_matcher.py -k test_qlinear_dequant_promotion_dynamic_cpu
    ```
    
    cc ezyang msaroufim bdhirsh anijain2305 chauhang voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire
    
    [ghstack-poisoned]
    leslie-fang-intel committed May 9, 2024
    Configuration menu
    Copy the full SHA
    334b31e View commit details
    Browse the repository at this point in the history