Use torch._check for safety assert in _reshape_view_helper #125187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125187
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5cad1e7 with merge base f1d1e32 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
added a commit
that referenced
this pull request
Apr 29, 2024
Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: 697f283d8fd6b8d5e378c5f031a59ca84fe3a2e9 Pull Request resolved: #125187
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
miladm and
SherlockNoMad
albanD
approved these changes
Apr 30, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
andoorve
pushed a commit
to andoorve/pytorch
that referenced
this pull request
May 1, 2024
…25187) Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#125187 Approved by: https://github.com/albanD
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 3, 2024
Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: #125187 Approved by: https://github.com/albanD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Signed-off-by: Edward Z. Yang [email protected]