Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored _remove_auto_functionalization_from_graph_helper #125180

Closed
wants to merge 3 commits into from
Closed

Refactored _remove_auto_functionalization_from_graph_helper #125180

wants to merge 3 commits into from

Conversation

jainapurva
Copy link
Contributor

@jainapurva jainapurva commented Apr 29, 2024 •
edited

Stack from ghstack (oldest at bottom):

Summary:
Refactored the function to remove multiple list slicing and use unused variable.

Test Plan:
python test/run_test.py

Reviewers: @drisspg

Subscribers:

Tasks: T187526123 T93492332

Tags: @pytorchbot merge -r viable/strict

@jainapurva
Refactored _remove_auto_functionalization_from_graph_helper
ec6dad7 
Summary:
Refactored the function to remove multiple list slicing and use unused variable.

Test Plan:
python test/run_test.py

Reviewers:
@drisspg
Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 29, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125180

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit dff669d with merge base b7d67e4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 29, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

jainapurva added a commit that referenced this pull request Apr 29, 2024
@jainapurva
Refactored _remove_auto_functionalization_from_graph_helper
702cbf6 
Summary:
Refactored the function to remove multiple list slicing and use unused variable.

Test Plan:
python test/run_test.py

Reviewers:
drisspg
Subscribers:

Tasks:

Tags:

ghstack-source-id: 50d58677abfa8c259a162f482924b36904abee3e
Pull Request resolved: #125180
@jainapurva jainapurva requested a review from drisspg April 29, 2024 19:08
drisspg
drisspg approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@drisspg drisspg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jainapurva
Copy link
Contributor Author

@pytorchbot merge -r viable/strict

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 29, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@jainapurva
Update
bb9302f 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/jainapurva/1/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/125180)

pytorchmergebot pushed a commit that referenced this pull request Apr 29, 2024
@jainapurva
Refactored _remove_auto_functionalization_from_graph_helper
3e0bd43 
Summary:
Refactored the function to remove multiple list slicing and use unused variable.

Test Plan:
python test/run_test.py

Reviewers:
drisspg
Subscribers:

Tasks:

Tags:

ghstack-source-id: d07e803f7453b92cc51682e56e639395f488657e
Pull Request resolved: #125180
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@jainapurva
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Apr 30, 2024
@jainapurva
Copy link
Contributor Author

@pytorchbot merge -r viable/strict

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@jainapurva
Update
dff669d 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/jainapurva/1/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/125180)

pytorchmergebot pushed a commit that referenced this pull request Apr 30, 2024
@jainapurva
Refactored _remove_auto_functionalization_from_graph_helper
594154c 
Summary:
Refactored the function to remove multiple list slicing and use unused variable.

Test Plan:
python test/run_test.py

Reviewers:
drisspg
Subscribers:

Tasks:

Tags:

ghstack-source-id: c24ddc5ba9a18ee6731a88045d8d0eebf5c530c4
Pull Request resolved: #125180
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

andoorve pushed a commit to andoorve/pytorch that referenced this pull request May 1, 2024
@jainapurva @andoorve
Refactored _remove_auto_functionalization_from_graph_helper (pytorch#…
5a3791b 
…125180)

Summary:
Refactored the function to remove multiple list slicing and use unused variable.

Test Plan:
python test/run_test.py

Reviewers: @drisspg

Subscribers:

Tasks: [T187526123](https://www.internalfb.com/intern/tasks/?t=187526123) [T93492332](https://www.internalfb.com/intern/tasks/?t=93492332)

Tags: @pytorchbot merge -r viable/strict
Pull Request resolved: pytorch#125180
Approved by: https://github.com/drisspg
petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024
@jainapurva @petrex
Refactored _remove_auto_functionalization_from_graph_helper (pytorch#…
33898e8 
…125180)

Summary:
Refactored the function to remove multiple list slicing and use unused variable.

Test Plan:
python test/run_test.py

Reviewers: @drisspg

Subscribers:

Tasks: [T187526123](https://www.internalfb.com/intern/tasks/?t=187526123) [T93492332](https://www.internalfb.com/intern/tasks/?t=93492332)

Tags: @pytorchbot merge -r viable/strict
Pull Request resolved: pytorch#125180
Approved by: https://github.com/drisspg
jainapurva added a commit that referenced this pull request May 3, 2024
@jainapurva
Refactored _remove_auto_functionalization_from_graph_helper
ad03711 
Summary:
Refactored the function to remove multiple list slicing and use unused variable.

Test Plan:
python test/run_test.py

Reviewers:
drisspg
Subscribers:

Tasks:

Tags:

ghstack-source-id: 50d58677abfa8c259a162f482924b36904abee3e
Pull Request resolved: #125180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drisspg drisspg drisspg approved these changes

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@gmagogsfm gmagogsfm Awaiting requested review from gmagogsfm gmagogsfm is a code owner

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jainapurva @pytorchmergebot @drisspg