TEST: add some random logging #125176
Draft
TEST: add some random logging #125176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125176
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 41f4958 with merge base e7631d6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
c-p-i-o
added a commit
that referenced
this pull request
Apr 29, 2024
Summary: Testing OTEL in PyTorch to see what automation workflows break. This change won't be commited into the main branch. ghstack-source-id: 6043560b23b4b0588ac441d6602d0980ae025c9b Pull Request resolved: #125176
yurishkuro
reviewed
Apr 29, 2024
torch/csrc/serialization.cpp
Outdated
| opentelemetry::trace::StartSpanOptions start; | ||
| start.start_system_time = SystemTimestamp(std::chrono::nanoseconds(300)); | ||
| std::shared_ptr<opentelemetry::metrics::Counter<uint64_t>> counter{ | ||
| new opentelemetry::metrics::NoopCounter<uint64_t>("testi2", "none", "unitless")}; |
There was a problem hiding this comment.
rather than binding to concrete implementation you want to pull it from the Meter:
auto meter = opentelemetry::metrics::Provider::GetMeterProvider()->GetMeter(...);
auto counter = meter->CreateUInt64Counter(...);
Also, it's more efficient to create counter once as static or member variable.
c-p-i-o
added a commit
that referenced
this pull request
Apr 29, 2024
Summary: Testing OTEL in PyTorch to see what automation workflows break. This change won't be commited into the main branch. ghstack-source-id: d7b9eaa8b8489c9cee3053a8b1b3b801bb4d6c45 Pull Request resolved: #125176
c-p-i-o
added a commit
that referenced
this pull request
Apr 29, 2024
Summary: Testing OTEL in PyTorch to see what automation workflows break. This change won't be commited into the main branch. ghstack-source-id: b7121de3b50bd5c7569eba3f7dd52b0148c05619 Pull Request resolved: #125176
c-p-i-o
added a commit
that referenced
this pull request
Apr 29, 2024
Summary: Testing OTEL in PyTorch to see what automation workflows break. This change won't be commited into the main branch. ghstack-source-id: 182052093070b5182350a1b2c6d1c20e6b4607a6 Pull Request resolved: #125176
c-p-i-o
added a commit
that referenced
this pull request
Apr 30, 2024
Summary: Testing OTEL in PyTorch to see what automation workflows break. This change won't be commited into the main branch. ghstack-source-id: 099915604e42c865b6de349fd66c99dc81885c3d Pull Request resolved: #125176
c-p-i-o
added a commit
that referenced
this pull request
Apr 30, 2024
Summary: Testing OTEL in PyTorch to see what automation workflows break. This change won't be commited into the main branch. ghstack-source-id: 55109b7fd9162bafaff03a5dd21442637b64d01c Pull Request resolved: #125176
|
@c-p-i-o has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Testing OTEL in PyTorch to see what automation workflows break.
This change won't be commited into the main branch.
Differential Revision: D56786948