Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ATen][CUDA][AMP] Fix dtype mismatch in linalg_vector_norm #125175

Closed
wants to merge 7 commits into from

Conversation

Aidyn-A
Copy link
Collaborator

@Aidyn-A Aidyn-A commented Apr 29, 2024

Copy link

pytorch-bot bot commented Apr 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125175

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit ce40913 with merge base 07d3af8 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: linalg_frontend release notes category label Apr 29, 2024
@Aidyn-A Aidyn-A added module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul and removed release notes: linalg_frontend release notes category labels Apr 29, 2024
@pytorch-bot pytorch-bot bot added the release notes: linalg_frontend release notes category label Apr 29, 2024
@Aidyn-A Aidyn-A marked this pull request as draft April 29, 2024 20:56
aten/src/ATen/native/LinearAlgebra.cpp Outdated Show resolved Hide resolved
@Aidyn-A Aidyn-A marked this pull request as ready for review April 30, 2024 20:15
@Aidyn-A
Copy link
Collaborator Author

Aidyn-A commented Apr 30, 2024

I believe the test failure is unrelated. @lezcano, can you take another look?

Copy link
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more reasonable. Thank you!

@lezcano
Copy link
Collaborator

lezcano commented May 1, 2024

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 1, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 2, 5, linux.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: amp (automated mixed precision) autocast module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul open source release notes: linalg_frontend release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CUDA][AMP] Size-1 (scalar) norms are broken on CUDA + AMP following #122143
5 participants