Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clamp op int variant #3680

Closed
wants to merge 2 commits into from

Conversation

nathanaelsee
Copy link
Contributor

Summary:
Adding int variant of clamp.

Adding as a separate op to specify int only for clamp, as int variant for some other ops don't make sense

Differential Revision: D57514823

Copy link

pytorch-bot bot commented May 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3680

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 3a635e2 with merge base 5fd2a11 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 20, 2024
Summary:

bool is not currently supported in operators or in shader generation code

Differential Revision: D57509811
Summary:

Adding int variant of clamp.

Adding as a separate op to specify int only for clamp, as int variant for some other ops don't make sense

Differential Revision: D57514823
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57514823

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57514823

nathanaelsee added a commit to nathanaelsee/executorch that referenced this pull request May 20, 2024
Summary:

Adding int variant of clamp.

Adding as a separate op to specify int only for clamp, as int variant for some other ops don't make sense

Differential Revision: D57514823
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in c3b423c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants