Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in missing pieces from macro layers for folly #3635

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bigfootjon
Copy link
Member

Summary:
I found these by repeatedly running dotslash-oss ./buck2 targets ... in the GitHub version of folly.

(third-party changes are in the next diff, split for reviewability)

These changes are just hacks to convert fbcode's macro layer to the buck2 prelude with the minimal work possible.

Reviewed By: namanahuja

Differential Revision: D57383968

Summary:
I found these by repeatedly running `dotslash-oss ./buck2 targets ...` in the GitHub version of folly.

(third-party changes are in the next diff, split for reviewability)

These changes are just hacks to convert fbcode's macro layer to the buck2 prelude with the minimal work possible.

Reviewed By: namanahuja

Differential Revision: D57383968
Copy link

pytorch-bot bot commented May 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3635

Note: Links to docs will display an error until the docs builds have been completed.

❌ 34 New Failures

As of commit 3a181e9 with merge base ad419a5 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 16, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57383968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants