-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill in missing pieces from macro layers for folly #3635
Open
bigfootjon
wants to merge
1
commit into
main
Choose a base branch
from
export-D57383968
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,011
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: I found these by repeatedly running `dotslash-oss ./buck2 targets ...` in the GitHub version of folly. (third-party changes are in the next diff, split for reviewability) These changes are just hacks to convert fbcode's macro layer to the buck2 prelude with the minimal work possible. Reviewed By: namanahuja Differential Revision: D57383968
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3635
Note: Links to docs will display an error until the docs builds have been completed. ❌ 34 New FailuresAs of commit 3a181e9 with merge base ad419a5 (): NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
May 16, 2024
This pull request was exported from Phabricator. Differential Revision: D57383968 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I found these by repeatedly running
dotslash-oss ./buck2 targets ...
in the GitHub version of folly.(third-party changes are in the next diff, split for reviewability)
These changes are just hacks to convert fbcode's macro layer to the buck2 prelude with the minimal work possible.
Reviewed By: namanahuja
Differential Revision: D57383968