Making BERT_pytorch work with MPS backend #1434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulinseth
commented
Feb 24, 2023
| @@ -86,7 +86,7 @@ def __init__(self, test, device, batch_size=None, jit=False, extra_args=[]): | |||
| '--vocab_path', f'{root}/data/vocab.small', | |||
| '--output_path', 'bert.model', | |||
| ]) # Avoid reading sys.argv here | |||
| args.with_cuda = self.device == 'cuda' | |||
| args.with_cuda = self.device == 'cuda' or self.device == 'mps' | |||
There was a problem hiding this comment.
Piggybacking on the cuda flag as i didn't want to create additional changes in the function signature.
There was a problem hiding this comment.
I suggest we remove the with_cuda flag and replace it with device and pass in self.device.
xuzhao9
reviewed
Feb 25, 2023
| @@ -35,8 +35,12 @@ def __init__(self, bert: BERT, vocab_size: int, | |||
| """ | |||
|
|
|||
| # Setup cuda device for BERT training, argument -c, --cuda should be true | |||
| cuda_condition = torch.cuda.is_available() and with_cuda | |||
| self.device = torch.device("cuda:0" if cuda_condition else "cpu") | |||
| if (with_cuda and torch.cuda.is_available()): | |||
There was a problem hiding this comment.
Same here, we can make it easier by using self.device = device
| @@ -86,7 +86,7 @@ def __init__(self, test, device, batch_size=None, jit=False, extra_args=[]): | |||
| '--vocab_path', f'{root}/data/vocab.small', | |||
| '--output_path', 'bert.model', | |||
| ]) # Avoid reading sys.argv here | |||
| args.with_cuda = self.device == 'cuda' | |||
| args.with_cuda = self.device == 'cuda' or self.device == 'mps' | |||
There was a problem hiding this comment.
I suggest we remove the with_cuda flag and replace it with device and pass in self.device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.