Call Application.post_stop Only if Application.stop was called
#4211
+12
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshil21
reviewed
May 20, 2024
| @@ -2441,7 +2440,8 @@ async def callback(*args, **kwargs): | |||
| app.run_polling(close_loop=False) | |||
|
|
|||
| # The important part here is that start(_polling) are *not* called! | |||
| assert called_callbacks == ["post_stop", "post_shutdown"] | |||
| # post_stop must not be called either, since we never called start() | |||
There was a problem hiding this comment.
Suggested change
| # post_stop must not be called either, since we never called start() | |
| # post_stop must not be called either, since we never called stop() |
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be merged (and possibly reviewed) after #4157. based this PR on the branch of #4157 since the bug mostly becomes visible after those changes.
closes #4210