win32: Avoid calling SetCommState() when there are no configuration c… #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges win32.SetCommState() is always called in the method _reconfigure_port. _reconfigure_port is used when changing timeout, but data corruption may occur in SetCommState() at this time. Similar to the serialposix.py implementation, avoid calling SetCommState() when there are no configuration changes. See https://electronics.stackexchange.com/questions/479343/frame-errors-character-stretching-of-cp2102n
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hanges
win32.SetCommState() is always called in the method _reconfigure_port. _reconfigure_port is used when changing timeout, but data corruption may occur in SetCommState() at this time.
Similar to the serialposix.py implementation, avoid calling SetCommState() when there are no configuration changes.
See https://electronics.stackexchange.com/questions/479343/frame-errors-character-stretching-of-cp2102n