/serial/tools/list_ports_linux.py: find ALL serial ports #709
+7
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbrock
commented
Jul 18, 2023
maartenbrock
commented
- /serial/tools/list_ports_linux.py: find ALL serial ports Instead of creating some random set of patterns ask Linux what patterns it supports.
- /serial/tools/list_ports_linux.py: optionally hide subsystems Instead of statically filtering out all 'platform' subsystem devices, accept a list of subsystems to hide. Many (embedded?) systems have real platform serial devices.
Instead of creating some random set of patterns ask Linux what patterns it supports.
Instead of statically filtering out all 'platform' subsystem devices, accept a list of subsystems to hide. Many (embedded?) systems have real platform serial devices.
maartenbrock
changed the title
This was referenced Jul 30, 2023
This was referenced Sep 21, 2023
Open
|
Is there anything blocking this from being merged? |
alexdewar
reviewed
Dec 5, 2023
|
|
||
| if include_links: | ||
| devices.update(list_ports_common.list_links(devices)) | ||
| return [info | ||
| for info in [SysFS(d) for d in devices] | ||
| if info.subsystem != "platform"] # hide non-present internal serial ports | ||
| if not info.subsystem in hide_subsystems] # hide non-present internal serial ports |
There was a problem hiding this comment.
How about:
return [info
for info in map(SysFS, devices)
if info.subsystem not in hide_subsystems] # hide non-present internal serial portsThere was a problem hiding this comment.
Either way, as long as it gets fixed.
|
ping @zsquareplusc |
1ace
reviewed
Feb 28, 2024
| devices.update(glob.glob('/dev/rfcomm*')) # BT serial devices | ||
| devices.update(glob.glob('/dev/ttyAP*')) # Advantech multi-port serial controllers | ||
| devices.update(glob.glob('/dev/ttyGS*')) # https://www.kernel.org/doc/Documentation/usb/gadget_serial.txt | ||
| drivers = open('/proc/tty/drivers').readlines() |
There was a problem hiding this comment.
You're leaking the fd here:
Suggested change
| drivers = open('/proc/tty/drivers').readlines() | |
| with open('/proc/tty/drivers') as drivers_file: | |
| drivers = drivers_file.readlines() |
There was a problem hiding this comment.
Great! When can this be applied?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.