Close opened file handler on closing the serial port #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the spy://___URI___?file=__SOME_FILE___&raw format for serial port the __SOME_FILE___ is opened and its file handler is not closed when the serial port is closed. This patch fixes this. By default the opened stream is 'stderr' which cannot be closed, so check for its existence is made.
|
Now I see that this is also fixed in other proposal, that do extends the spy functionality in #604 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the spy://URI?file=SOME_FILE_&raw format for serial port the SOME_FILE_ is opened and its file handler is not closed when the serial port is closed. This patch fixes this. By default the opened stream is 'stderr' which cannot be closed, so check for its existence is made.