New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type hint for `InputMediaVideo`’s `thumb` attribute #1262

Open

roj1512 wants to merge 2 commits into pyrogram:master from roj1512:patch-1

Contributor

roj1512 commented Apr 26, 2023

The thumb attribute can also be a BinaryIO as it is passed to a method in a position that can also accept a BinaryIO.

roj1512 and others added 2 commits

April 26, 2023 20:51


Fix type hint for InputMediaVideo’s thumb attribute

7d6cecb

The thumb attribute can also be a `BinaryIO` as it is [passed](https://github.com/pyrogram/pyrogram/blob/master/pyrogram/methods/messages/send_media_group.py#L165) to a method in a position that can also accept a `BinaryIO`.

Co-authored-by: Davide Galilei <[email protected]>


I literally forgot it is still the ‘90s in Pyrogram’s code base

a9dc18b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment