add drop_author parameter in methods/.../forward_messages.py, types.Message.reactions edited #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvrvgv
commented
Mar 13, 2023
| @@ -32,7 +32,8 @@ async def forward_messages( | |||
| message_ids: Union[int, Iterable[int]], | |||
| disable_notification: bool = None, | |||
| schedule_date: datetime = None, | |||
| protect_content: bool = None | |||
| protect_content: bool = None, | |||
| drop_author: bool = None | |||
There was a problem hiding this comment.
function parameter
if True - author will be hidden
kvrvgv
commented
Mar 13, 2023
| @@ -62,6 +63,9 @@ async def forward_messages( | |||
| protect_content (``bool``, *optional*): | |||
| Protects the contents of the sent message from forwarding and saving. | |||
|
|
|||
| drop_author (``bool``, *optional*): | |||
| Forwards messages without quoting the original author | |||
There was a problem hiding this comment.
docstring for new param
kvrvgv
commented
Mar 13, 2023
| @@ -87,7 +91,8 @@ async def forward_messages( | |||
| silent=disable_notification or None, | |||
| random_id=[self.rnd_id() for _ in message_ids], | |||
| schedule_date=utils.datetime_to_timestamp(schedule_date), | |||
| noforwards=protect_content | |||
| noforwards=protect_content, | |||
| drop_author=drop_author | |||
There was a problem hiding this comment.
pass parameter to raw.functions.messages.ForwardMessages
kvrvgv
commented
May 5, 2023
| self.reactions = reactions | ||
| self._reactions = reactions | ||
|
|
||
| @property |
kvrvgv
changed the title
|
@delivrance could you merge it? I also tested it and it works without any issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1211
My manual tests
Expect: Default forwarding
Expect: Same behavior
Expect: Forward without author account