Fix spinner style settings #1490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaiSforza
force-pushed
the
fixspinner
branch
2 times, most recently
from
d39c07e
to
7df0933
Compare
9 tasks
|
@Grub4K Nice, I hadn't seen that. Hopefully these get looked at. Yours is a bit simpler, but I figured that the project might as well get rid of the Also was hoping to get Textualize/rich#3359 merged so we could have a more similar workflow, as well. Then we could just have parse_style = lambda s: Spinner(s).name if option == 'spinner' else Style.parse(s)and remove all the extra conditional stuff. |
|
I'm so sorry for not responding! I'm getting ready to travel for my talk at PyCon and I won't have time until next week. |
Allows for customizing the spinner style finally! Previously it had a
problem where the attribute name was not `_style_level_spinner`, so it
was never getting set from the `initialize_styles` method. This made the
setting in the user's `config.toml` never see the light of day.
To fix this I also changed all of the `style_level_{level}` names to be
just `style_{level}`, cleaning up a bit of the code.
And for some reason the `Spinner` class doesn't keep a `name` attribute,
so I'll be poking the rich project about that in a minute, since I
basically had to create a `Spinner()` class with no ability to use it.
|
I merged the other PR so there is now a conflict, sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for customizing the spinner style finally! Previously it had a problem where the attribute name was not
_style_level_spinner, so it was never getting set from theinitialize_stylesmethod. This made the setting in the user'sconfig.tomlnever see the light of day.To fix this I also changed all of the
style_level_{level}names to be juststyle_{level}, cleaning up a bit of the code.And for some reason the
Spinnerclass doesn't keep anameattribute, so I'll be poking the rich project about that in a minute, since I basically had to create aSpinner()class with no ability to use it.