Concept version of upgrading based on preferred words #5987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a score configured per show.
|
DeepCode analyzed this pull request. |
p0psicles
changed the title
p0psicles
commented
Jan 11, 2019
medusa/classes.py
Outdated
| @@ -16,14 +16,15 @@ | |||
| # You should have received a copy of the GNU General Public License | |||
| # along with Medusa. If not, see <http://www.gnu.org/licenses/>. | |||
| """Collection of generic used classes.""" | |||
| from __future__ import unicode_literals | |||
| from __future__ import division, unicode_literals | |||
There was a problem hiding this comment.
rtms: division can be removed again.
p0psicles
commented
Jan 11, 2019
| return ', '.join([Quality.qualityStrings[quality] for quality in qualities or [] | ||
| if quality and quality in Quality.qualityStrings]) or 'None' | ||
|
|
||
| def want_episode(self, season, episode, quality): |
There was a problem hiding this comment.
@medariox i've moved want_episode from the Series class to Result class. Imo it looks allot cleaner, with less parameter. And it just feels like this is a better home.
# Conflicts: # medusa/databases/main_db.py # medusa/search/core.py
* Added todo in query.
…usa/Medusa into feature/upgrade-pref-words # Conflicts: # themes/dark/assets/css/vendors.css # themes/dark/assets/js/app.js # themes/dark/assets/js/index.js # themes/dark/assets/js/vendors.js # themes/light/assets/css/vendors.css # themes/light/assets/js/app.js # themes/light/assets/js/index.js # themes/light/assets/js/vendors.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a score configured per show.
TODO:
POC for #5184 #6239