Bug Fixes for Inconsistent Download Location with FlexGet #866
Conversation
This is a fix for the second of [two bugs mangling download paths passed by FlexGet](pyload#808 (comment)). Requires a modification of FlexGet to work.
The original modification did not account for folder_per_package being set to no, causing folder parameters in that scenario to be set to "". As the introduction of the parameter includes a default value of "", the else clause which used to do this and now causes issues can simply be deleted to accommodate the change. Thanks go to Firefly for noting the bug and its simple solution.
Revisited this bug fix to account for the recent inclusion of save_path in the AddPackage function after the pull request was flagged as a conflicting merge.
While the new official code removes save_path from its specific point of proper use to folder names in general. This will again strip colons and slashes from paths added via the API, mangling download paths from, for example, X:\Intended\Folder to D:\Default pyLoad Download Folder\XIntendedFolder. The prior code is clunkier but fit-for-purpose.
Mixed the recent official changes into the bug fixes for [Inconsistent Download Locations with FlexGet](pyload#808). Looks solid. Pushing to sasese\stable and into the pull request.
Merge API fixes into sasese\stable for merge with pyLoad.
Removed the inline description of the modification and an unintended addition of leading spaces. Functionally identical: the deletion of save_path from the folder property, to prevent the bug which caused download locations, added via the API, to be mangled from X:\Intended\Folder to D:\Default pyLoad Download Folder\XintendedFolder, by stripping special characters from the path. The intent of the original code is unclear, but may have been a hold-over.
|
@vuolter I checked out the conflict: it is good to go, changes cover the new behavior - and integrate your new code. If not folder tests whether the new parameter is used and the omission of else: folder="" prevents folder from being emptied when folder_per_package is set to no (see link), and has become obsolete as the new folder parameter defaults to "". |
vuolter
added
testing
API change
|
@vuolter I just noticed I submitted the pull request to the wrong branch. Should I resubmit a pull request from sasese\stable to pyload\master? |
|
Note: development is based on the correct master branch. |
|
API will not change until 0.4.11 u.u |
|
any updates on this? i would even pay to have a working workaround before 0.4.11 ^^ waiting already over a year :( |
|
Two years down the road these two bug fixes are still need and prove to work with most recent Flexget pyload plugin, To cut a long story short, one should replace the files from the 0.4.9 2011 release with these two: pyload/module/Api.py - a835336 on Nov 15, 2014 pyload/module/PyPackage.py - ef704fe on Nov 16, 2014 |
|
@timofonic It would seem so. If you compare with Api.py from stable branch (dated 22 Nov 2014) you will see these fixes are not applied there. They seem to be on the Pull Request List still to be processed. Eventually :/ |
|
|
The commits in this pull request resolve both bugs which cause Inconsistent Download Locations with FlexGet (issue #808).
The modification of pyPackage resolves the first bug, which causes download locations passed by FlexGet to be mangled from (for example) X:\Intended\Folder to D:\Default pyLoad Download Folder\XIntendedFolder.
The modifications of the API and FlexGet's pyload output plugin resolve the second bug, which causes download locations passed by FlexGet to be mangled from (for example) X:\Intended\Folder to D:\Default pyLoad Download Folder\Package Name. The modifications of the API are such that they maintain compatibility with FlexGet for installations which have not been updated to the new pyload output plugin, although the fix won't work until it is.